ASoC: rt5668: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:20 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:10:08 +0000 (13:10 +0000)
cppcheck warning:

sound/soc/codecs/rt5668.c:2185:61: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT5668_PLL_M_SFT |
                                                            ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-18-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt5668.c

index bc69adc9c8b707bb8c3e292e35cd7a9ec474e093..d966d6d1bf644676ec615ee1daabf8a9301915d3 100644 (file)
@@ -2182,8 +2182,8 @@ static int rt5668_set_component_pll(struct snd_soc_component *component,
        snd_soc_component_write(component, RT5668_PLL_CTRL_1,
                pll_code.n_code << RT5668_PLL_N_SFT | pll_code.k_code);
        snd_soc_component_write(component, RT5668_PLL_CTRL_2,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT5668_PLL_M_SFT |
-               pll_code.m_bp << RT5668_PLL_M_BP_SFT);
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT5668_PLL_M_SFT) |
+               (pll_code.m_bp << RT5668_PLL_M_BP_SFT));
 
        rt5668->pll_in = freq_in;
        rt5668->pll_out = freq_out;