drm/syncobj: reject invalid flags in drm_syncobj_find_fence
authorErik Kurzinger <ekurzinger@nvidia.com>
Fri, 19 Jan 2024 16:32:07 +0000 (08:32 -0800)
committerSimon Ser <contact@emersion.fr>
Thu, 22 Feb 2024 10:26:52 +0000 (11:26 +0100)
The only flag that is meaningful to drm_syncobj_find_fence is
DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT. It should return -EINVAL for any
other flag bits.

Signed-off-by: Erik Kurzinger <ekurzinger@nvidia.com>
Signed-off-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Acked-by: Simon Ser <contact@emersion.fr>
Link: https://patchwork.freedesktop.org/patch/msgid/20240119163208.3723457-2-ekurzinger@nvidia.com
drivers/gpu/drm/drm_syncobj.c

index 56b0677acfa3da9f31f9e7a6a3c97764c5248f13..fada77f04a8c31f27e5946c51f61c1a0d1233b5a 100644 (file)
@@ -441,6 +441,9 @@ int drm_syncobj_find_fence(struct drm_file *file_private,
        u64 timeout = nsecs_to_jiffies64(DRM_SYNCOBJ_WAIT_FOR_SUBMIT_TIMEOUT);
        int ret;
 
+       if (flags & ~DRM_SYNCOBJ_WAIT_FLAGS_WAIT_FOR_SUBMIT)
+               return -EINVAL;
+
        if (!syncobj)
                return -ENOENT;