mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()

damon_reclaim_init() allocates a memory chunk for ctx with
damon_new_ctx().  When damon_select_ops() fails, ctx is not released,
which will lead to a memory leak.

We should release the ctx with damon_destroy_ctx() when damon_select_ops()
fails to fix the memory leak.

Link: https://lkml.kernel.org/r/20220714063746.2343549-1-niejianglei2021@163.com
Fixes: 4d69c3457821 ("mm/damon/reclaim: use damon_select_ops() instead of damon_{v,p}a_set_operations()")
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c
index e69b807fefe4388a9f29c2b639bdd6388819318a..a7faf51b4bd4adaec23221468340cd9a6e83f166 100644 (file)
--- a/mm/damon/reclaim.c
+++ b/mm/damon/reclaim.c
@@ -435,8 +435,10 @@ static int __init damon_reclaim_init(void)
        if (!ctx)
                return -ENOMEM;
 
-       if (damon_select_ops(ctx, DAMON_OPS_PADDR))
+       if (damon_select_ops(ctx, DAMON_OPS_PADDR)) {
+               damon_destroy_ctx(ctx);
                return -EINVAL;
+       }
 
        ctx->callback.after_wmarks_check = damon_reclaim_after_wmarks_check;
        ctx->callback.after_aggregation = damon_reclaim_after_aggregation;