ALSA: emux: fix validation of snd_emux.num_ports

Both bounds had off-by-one errors.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Message-ID: <20240406064830.1029573-4-oswald.buddenhagen@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/synth/emux/emux_seq.c b/sound/synth/emux/emux_seq.c
index b227c7e0bc2ac91fb13553e692fcd77002345125..1adaa75df2f6a4e3a2053b3403935e1b877ae09c 100644 (file)
--- a/sound/synth/emux/emux_seq.c
+++ b/sound/synth/emux/emux_seq.c
@@ -65,11 +65,11 @@ snd_emux_init_seq(struct snd_emux *emu, struct snd_card *card, int index)
                return -ENODEV;
        }
 
-       if (emu->num_ports < 0) {
+       if (emu->num_ports <= 0) {
                snd_printk(KERN_WARNING "seqports must be greater than zero\n");
                emu->num_ports = 1;
-       } else if (emu->num_ports >= SNDRV_EMUX_MAX_PORTS) {
-               snd_printk(KERN_WARNING "too many ports."
+       } else if (emu->num_ports > SNDRV_EMUX_MAX_PORTS) {
+               snd_printk(KERN_WARNING "too many ports. "
                           "limited max. ports %d\n", SNDRV_EMUX_MAX_PORTS);
                emu->num_ports = SNDRV_EMUX_MAX_PORTS;
        }