mm/swap_slots.c: remove redundant NULL check
authorYang Li <abaci-bugfix@linux.alibaba.com>
Wed, 24 Feb 2021 20:02:55 +0000 (12:02 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 24 Feb 2021 21:38:28 +0000 (13:38 -0800)
Fix below warnings reported by coccicheck:

  mm/swap_slots.c:197:3-9: WARNING: NULL check before some freeing functions is not needed.

Link: https://lkml.kernel.org/r/1611214229-11225-1-git-send-email-abaci-bugfix@linux.alibaba.com
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/swap_slots.c

index 0357fbe706454754bfa09867d90dc4f1ecbe5a2e..be9de6d5b516f919ab996600cf04e7a94dc66b87 100644 (file)
@@ -193,8 +193,7 @@ static void drain_slots_cache_cpu(unsigned int cpu, unsigned int type,
                        cache->slots_ret = NULL;
                }
                spin_unlock_irq(&cache->free_lock);
-               if (slots)
-                       kvfree(slots);
+               kvfree(slots);
        }
 }