staging: rtl8192e: Remove useless equation in debug output
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Tue, 12 Sep 2023 19:28:05 +0000 (21:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Sep 2023 07:47:42 +0000 (09:47 +0200)
When "switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)))" results
in "case RTLLIB_STYPE_BEACON:" there is no need to calculate this again
inside "case" and when a frame is a beacon there is no need to print the
frame identifier again as it is explicit.
Same for PROBE RESPONSE and PROBE REQUEST. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/f3c8deddac66d11c41ba720e4048aba37e41e885.1694546300.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_rx.c

index 0e695b144b36b6025b9f083ae3d54f0481e20534..9f944eefa41edee885ae5a2a7b86826a04870a02 100644 (file)
@@ -2652,8 +2652,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,
 
        switch (WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl))) {
        case RTLLIB_STYPE_BEACON:
-               netdev_dbg(ieee->dev, "received BEACON (%d)\n",
-                          WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));
+               netdev_dbg(ieee->dev, "received BEACON\n");
                rtllib_process_probe_response(
                                ieee, (struct rtllib_probe_response *)header,
                                stats);
@@ -2666,14 +2665,12 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee,
                break;
 
        case RTLLIB_STYPE_PROBE_RESP:
-               netdev_dbg(ieee->dev, "received PROBE RESPONSE (%d)\n",
-                          WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));
+               netdev_dbg(ieee->dev, "received PROBE RESPONSE\n");
                rtllib_process_probe_response(ieee,
                              (struct rtllib_probe_response *)header, stats);
                break;
        case RTLLIB_STYPE_PROBE_REQ:
-               netdev_dbg(ieee->dev, "received PROBE REQUEST (%d)\n",
-                          WLAN_FC_GET_STYPE(le16_to_cpu(header->frame_ctl)));
+               netdev_dbg(ieee->dev, "received PROBE REQUEST\n");
                if ((ieee->softmac_features & IEEE_SOFTMAC_PROBERS) &&
                    (ieee->iw_mode == IW_MODE_ADHOC &&
                    ieee->link_state == MAC80211_LINKED))