net: ipa: Remove unnecessary print function dev_err()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Mon, 15 Apr 2024 03:14:56 +0000 (11:14 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Apr 2024 00:15:20 +0000 (17:15 -0700)
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.

./drivers/net/ipa/ipa_interrupt.c:300:2-9: line 300 is redundant because platform_get_irq() already prints an error.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8756
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240415031456.10805-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ipa/ipa_interrupt.c

index c3e8784d51d913eb0eb754a026984804449720ab..c44ec05f71e6fe1a4e5d175efe5ecb2b55ede0f2 100644 (file)
@@ -291,16 +291,12 @@ void ipa_interrupt_deconfig(struct ipa *ipa)
 /* Initialize the IPA interrupt structure */
 struct ipa_interrupt *ipa_interrupt_init(struct platform_device *pdev)
 {
-       struct device *dev = &pdev->dev;
        struct ipa_interrupt *interrupt;
        int irq;
 
        irq = platform_get_irq_byname(pdev, "ipa");
-       if (irq <= 0) {
-               dev_err(dev, "DT error %d getting \"ipa\" IRQ property\n", irq);
-
+       if (irq <= 0)
                return ERR_PTR(irq ? : -EINVAL);
-       }
 
        interrupt = kzalloc(sizeof(*interrupt), GFP_KERNEL);
        if (!interrupt)