ALSA: hda: generic: Remove obsolete call to ledtrig_audio_get
authorHeiner Kallweit <hkallweit1@gmail.com>
Sat, 13 Jan 2024 16:08:54 +0000 (17:08 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 15 Jan 2024 11:43:08 +0000 (12:43 +0100)
Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to
ensure the initial brightness is set") the audio triggers have an
activate callback which sets the LED brightness as soon as the
(default) trigger is bound to the LED device. So we can remove the
call to ledtrig_audio_get.

Positive side effect: We have no code dependency to ledtrig-audio any
longer, therefore, if built as module, it's no longer loaded if not
needed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://lore.kernel.org/r/3dc9167d-fb33-43a6-baa6-dbef8b5da7b9@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_generic.c

index bf685d01259d30070aaf3ac7f3ed3204bc30c5bd..de2a3d08c73c1a7c49061bbe8a7fbb1a29664b8d 100644 (file)
@@ -3946,7 +3946,6 @@ static int create_mute_led_cdev(struct hda_codec *codec,
        cdev->max_brightness = 1;
        cdev->default_trigger = micmute ? "audio-micmute" : "audio-mute";
        cdev->brightness_set_blocking = callback;
-       cdev->brightness = ledtrig_audio_get(idx);
        cdev->flags = LED_CORE_SUSPENDRESUME;
 
        err = led_classdev_register(&codec->core.dev, cdev);