fs: dlm: Simplify buffer size computation in dlm_create_debug_file()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 10 Oct 2023 22:04:41 +0000 (18:04 -0400)
committerDavid Teigland <teigland@redhat.com>
Thu, 12 Oct 2023 20:19:29 +0000 (15:19 -0500)
Use sizeof(name) instead of the equivalent, but hard coded,
DLM_LOCKSPACE_LEN + 8.

This is less verbose and more future proof.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/debug_fs.c

index 5aabcb6f0f157c6291c3cff12f6cdab8eca62897..e9726c6cbdf20f2cadf66e6cdc9e449e1b67904b 100644 (file)
@@ -986,7 +986,7 @@ void dlm_create_debug_file(struct dlm_ls *ls)
        /* format 2 */
 
        memset(name, 0, sizeof(name));
-       snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_locks", ls->ls_name);
+       snprintf(name, sizeof(name), "%s_locks", ls->ls_name);
 
        ls->ls_debug_locks_dentry = debugfs_create_file(name,
                                                        0644,
@@ -997,7 +997,7 @@ void dlm_create_debug_file(struct dlm_ls *ls)
        /* format 3 */
 
        memset(name, 0, sizeof(name));
-       snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_all", ls->ls_name);
+       snprintf(name, sizeof(name), "%s_all", ls->ls_name);
 
        ls->ls_debug_all_dentry = debugfs_create_file(name,
                                                      S_IFREG | S_IRUGO,
@@ -1008,7 +1008,7 @@ void dlm_create_debug_file(struct dlm_ls *ls)
        /* format 4 */
 
        memset(name, 0, sizeof(name));
-       snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_toss", ls->ls_name);
+       snprintf(name, sizeof(name), "%s_toss", ls->ls_name);
 
        ls->ls_debug_toss_dentry = debugfs_create_file(name,
                                                       S_IFREG | S_IRUGO,
@@ -1017,7 +1017,7 @@ void dlm_create_debug_file(struct dlm_ls *ls)
                                                       &format4_fops);
 
        memset(name, 0, sizeof(name));
-       snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_waiters", ls->ls_name);
+       snprintf(name, sizeof(name), "%s_waiters", ls->ls_name);
 
        ls->ls_debug_waiters_dentry = debugfs_create_file(name,
                                                          0644,
@@ -1028,7 +1028,7 @@ void dlm_create_debug_file(struct dlm_ls *ls)
        /* format 5 */
 
        memset(name, 0, sizeof(name));
-       snprintf(name, DLM_LOCKSPACE_LEN + 8, "%s_queued_asts", ls->ls_name);
+       snprintf(name, sizeof(name), "%s_queued_asts", ls->ls_name);
 
        ls->ls_debug_queued_asts_dentry = debugfs_create_file(name,
                                                              0644,