drm/hyperv: Don't overwrite dirt_needed value set by host
authorSaurabh Sengar <ssengar@linux.microsoft.com>
Fri, 23 Sep 2022 10:09:50 +0000 (10:09 +0000)
committerWei Liu <wei.liu@kernel.org>
Fri, 23 Sep 2022 10:11:20 +0000 (10:11 +0000)
Existing code is causing a race condition where dirt_needed value is
already set by the host and gets overwritten with default value. Remove
this default setting of dirt_needed, to avoid overwriting the value
received in the channel callback set by vmbus_open. Removing this
setting also means the default value for dirt_needed is changed to false
as it's allocated by kzalloc which is similar to legacy hyperv_fb driver.

Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Reviewed-by: Dexuan Cui <decui@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/1662996766-19304-1-git-send-email-ssengar@linux.microsoft.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
drivers/gpu/drm/hyperv/hyperv_drm_drv.c

index f84d39762a72bef2a62fd904d0c9a59984ff6f4f..ca127ff797f756ad1b32b318edccf5233d2bbc95 100644 (file)
@@ -142,8 +142,6 @@ static int hyperv_vmbus_probe(struct hv_device *hdev,
        if (ret)
                drm_warn(dev, "Failed to update vram location.\n");
 
-       hv->dirt_needed = true;
-
        ret = hyperv_mode_config_init(hv);
        if (ret)
                goto err_free_mmio;