fs/ntfs3: Use the same order for acl pointer check in ntfs_init_acl
authorYang Xu <xuyang2018.jy@fujitsu.com>
Wed, 20 Apr 2022 08:48:00 +0000 (11:48 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 9 Jun 2022 16:16:18 +0000 (19:16 +0300)
For the readability and unity of the code, adjust the order

Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Reviewed-by: Kari Argillander <kari.argillander@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/xattr.c

index 5e0e0280e70debaac0c9e9478a65853b7deb8c1b..2d29afe4b40b17bb37313833d2178e9589bf2722 100644 (file)
@@ -706,13 +706,13 @@ int ntfs_init_acl(struct user_namespace *mnt_userns, struct inode *inode,
                inode->i_default_acl = NULL;
        }
 
-       if (!acl)
-               inode->i_acl = NULL;
-       else {
+       if (acl) {
                if (!err)
                        err = ntfs_set_acl_ex(mnt_userns, inode, acl,
                                              ACL_TYPE_ACCESS, true);
                posix_acl_release(acl);
+       } else {
+               inode->i_acl = NULL;
        }
 
        return err;