spi: s3c64xx: return ETIMEDOUT for wait_for_completion_timeout()
authorTudor Ambarus <tudor.ambarus@linaro.org>
Wed, 7 Feb 2024 12:04:27 +0000 (12:04 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 8 Feb 2024 16:33:36 +0000 (16:33 +0000)
ETIMEDOUT is more specific than EIO, use it for
wait_for_completion_timeout().

Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org>
Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20240207120431.2766269-14-tudor.ambarus@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-s3c64xx.c

index fbd500f26765ee103879b493e23ba37ebf450701..470610431ef86e7dae2924cf9a64ec7c36130ee4 100644 (file)
@@ -527,7 +527,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
 
        /*
         * If the previous xfer was completed within timeout, then
-        * proceed further else return -EIO.
+        * proceed further else return -ETIMEDOUT.
         * DmaTx returns after simply writing data in the FIFO,
         * w/o waiting for real transmission on the bus to finish.
         * DmaRx returns only after Dma read data from FIFO which
@@ -548,7 +548,7 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd,
 
        /* If timed out while checking rx/tx status return error */
        if (!val)
-               return -EIO;
+               return -ETIMEDOUT;
 
        return 0;
 }
@@ -578,7 +578,7 @@ static int s3c64xx_wait_for_pio(struct s3c64xx_spi_driver_data *sdd,
        if (use_irq) {
                val = msecs_to_jiffies(ms);
                if (!wait_for_completion_timeout(&sdd->xfer_completion, val))
-                       return -EIO;
+                       return -ETIMEDOUT;
        }
 
        val = msecs_to_loops(ms);