usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr'
authorLee Jones <lee.jones@linaro.org>
Mon, 6 Jul 2020 13:33:32 +0000 (14:33 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jul 2020 15:19:58 +0000 (17:19 +0200)
Fixes the following W=1 kernel build warning(s):

 drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’:
 drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable]
 626 | u8 addr;
 | ^~~~

Cc: Felipe Balbi <balbi@kernel.org>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Link: https://lore.kernel.org/r/20200706133341.476881-24-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/udc/max3420_udc.c

index 23f33946d80c4c85f6070fc51fe4612f665a7410..52884bae4af11d0e72fb887dfeba8be8c85086b0 100644 (file)
@@ -623,7 +623,6 @@ static void max3420_set_clear_feature(struct max3420_udc *udc)
 static void max3420_handle_setup(struct max3420_udc *udc)
 {
        struct usb_ctrlrequest setup;
-       u8 addr;
 
        spi_rd_buf(udc, MAX3420_REG_SUDFIFO, (void *)&setup, 8);
 
@@ -647,7 +646,7 @@ static void max3420_handle_setup(struct max3420_udc *udc)
                                USB_TYPE_STANDARD | USB_RECIP_DEVICE)) {
                        break;
                }
-               addr = spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
+               spi_rd8_ack(udc, MAX3420_REG_FNADDR, 1);
                dev_dbg(udc->dev, "Assigned Address=%d\n", udc->setup.wValue);
                return;
        case USB_REQ_CLEAR_FEATURE: