net/mlx5e: Remove the duplicating check for striding RQ when enabling LRO
authorMaxim Mikityanskiy <maximmi@nvidia.com>
Tue, 12 Apr 2022 18:59:53 +0000 (21:59 +0300)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 13 Jul 2022 22:56:49 +0000 (15:56 -0700)
LRO requires striding RQ and checks that it's enabled at two places:
mlx5e_fix_features and set_feature_lro. This commit keeps only one check
at mlx5e_fix_features and removes the duplicating one in
set_feature_lro.

Signed-off-by: Maxim Mikityanskiy <maximmi@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index be84f800e122139f20bd04bef60aee6d0d368cce..cac4022ba7f310ba890ee9118c1497e2ce2c4d79 100644 (file)
@@ -3595,12 +3595,6 @@ static int set_feature_lro(struct net_device *netdev, bool enable)
        mutex_lock(&priv->state_lock);
 
        cur_params = &priv->channels.params;
-       if (enable && !MLX5E_GET_PFLAG(cur_params, MLX5E_PFLAG_RX_STRIDING_RQ)) {
-               netdev_warn(netdev, "can't set LRO with legacy RQ\n");
-               err = -EINVAL;
-               goto out;
-       }
-
        new_params = *cur_params;
 
        if (enable)