serial: pch_uart: CIRC_CNT_TO_END() is enough
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tue, 23 Aug 2022 14:18:39 +0000 (17:18 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Aug 2022 12:23:05 +0000 (14:23 +0200)
Testing also CIRC_CNT() with CIRC_CNT_TO_END() is unnecessary because
to latter alone covers all necessary cases.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20220823141839.165244-3-ilpo.jarvinen@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/pch_uart.c

index 11ba5df0618fadcf7a24bb4435a9ff23ae70eb30..c59ce788657999dbd1931b5e8aef8f3e7ddd118e 100644 (file)
@@ -898,9 +898,7 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv)
                fifo_size--;
        }
 
-       bytes = min((int)CIRC_CNT(xmit->head, xmit->tail,
-                            UART_XMIT_SIZE), CIRC_CNT_TO_END(xmit->head,
-                            xmit->tail, UART_XMIT_SIZE));
+       bytes = CIRC_CNT_TO_END(xmit->head, xmit->tail, UART_XMIT_SIZE);
        if (!bytes) {
                dev_dbg(priv->port.dev, "%s 0 bytes return\n", __func__);
                pch_uart_hal_disable_interrupt(priv, PCH_UART_HAL_TX_INT);