usb: ehci-exynos: Use devm_clk_get_enabled() helpers

The devm_clk_get_enabled() helpers:
    - call devm_clk_get()
    - call clk_prepare_enable() and register what is needed in order to
     call clk_disable_unprepare() when needed, as a managed resource.

This simplifies the code and avoids the calls to clk_disable_unprepare().

Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20240412142317.5191-2-linux.amoon@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index f644b131cc0b5a478b57142463e24fe2df739dfd..e2303757bc0fa15046d5ff443e103dfa1d3e0aa3 100644 (file)
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -159,20 +159,16 @@ static int exynos_ehci_probe(struct platform_device *pdev)
 
        err = exynos_ehci_get_phy(&pdev->dev, exynos_ehci);
        if (err)
-               goto fail_clk;
+               goto fail_io;
 
-       exynos_ehci->clk = devm_clk_get(&pdev->dev, "usbhost");
+       exynos_ehci->clk = devm_clk_get_enabled(&pdev->dev, "usbhost");
 
        if (IS_ERR(exynos_ehci->clk)) {
                dev_err(&pdev->dev, "Failed to get usbhost clock\n");
                err = PTR_ERR(exynos_ehci->clk);
-               goto fail_clk;
+               goto fail_io;
        }
 
-       err = clk_prepare_enable(exynos_ehci->clk);
-       if (err)
-               goto fail_clk;
-
        hcd->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
        if (IS_ERR(hcd->regs)) {
                err = PTR_ERR(hcd->regs);
@@ -223,8 +219,6 @@ fail_add_hcd:
        exynos_ehci_phy_disable(&pdev->dev);
        pdev->dev.of_node = exynos_ehci->of_node;
 fail_io:
-       clk_disable_unprepare(exynos_ehci->clk);
-fail_clk:
        usb_put_hcd(hcd);
        return err;
 }
@@ -240,8 +234,6 @@ static void exynos_ehci_remove(struct platform_device *pdev)
 
        exynos_ehci_phy_disable(&pdev->dev);
 
-       clk_disable_unprepare(exynos_ehci->clk);
-
        usb_put_hcd(hcd);
 }