wifi: mt76: mt7996: fix uninitialized variable in mt7996_irq_tasklet()
authorLorenzo Bianconi <lorenzo@kernel.org>
Tue, 19 Mar 2024 12:05:36 +0000 (13:05 +0100)
committerFelix Fietkau <nbd@nbd.name>
Thu, 2 May 2024 10:44:51 +0000 (12:44 +0200)
Set intr1 to 0 in mt7996_irq_tasklet() in order to avoid possible
uninitialized variable usage if wed is not active for hif2.

Fixes: 83eafc9251d6 ("wifi: mt76: mt7996: add wed tx support")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7996/mmio.c

index 304e5fd1480340db0c147e8f4bf65f8861665a89..928a9663b49e0ccba21d7d85bcd0ba7e1d5ebbc5 100644 (file)
@@ -519,7 +519,7 @@ static void mt7996_irq_tasklet(struct tasklet_struct *t)
        struct mt7996_dev *dev = from_tasklet(dev, t, mt76.irq_tasklet);
        struct mtk_wed_device *wed = &dev->mt76.mmio.wed;
        struct mtk_wed_device *wed_hif2 = &dev->mt76.mmio.wed_hif2;
-       u32 i, intr, mask, intr1;
+       u32 i, intr, mask, intr1 = 0;
 
        if (dev->hif2 && mtk_wed_device_active(wed_hif2)) {
                mtk_wed_device_irq_set_mask(wed_hif2, 0);