ASoC: Intel: sof_cs42l42: use common module for DAI link generation
authorBrent Lu <brent.lu@intel.com>
Thu, 8 Feb 2024 16:55:29 +0000 (10:55 -0600)
committerMark Brown <broonie@kernel.org>
Thu, 8 Feb 2024 21:23:07 +0000 (21:23 +0000)
Use intel_board module to generate DAI link array and update num_links
field in snd_soc_card structure.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: Brent Lu <brent.lu@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20240208165545.93811-9-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/sof_cs42l42.c

index c2442bf8ced060a7f0e96c8ff1a3306af5bd7c87..323b86c42ef954ea397fd630867208ba5208cf3c 100644 (file)
 #define SOF_CS42L42_NUM_HDMIDEV_MASK           (GENMASK(9, 7))
 #define SOF_CS42L42_NUM_HDMIDEV(quirk) \
        (((quirk) << SOF_CS42L42_NUM_HDMIDEV_SHIFT) & SOF_CS42L42_NUM_HDMIDEV_MASK)
-#define SOF_CS42L42_DAILINK_SHIFT              10
-#define SOF_CS42L42_DAILINK_MASK               (GENMASK(24, 10))
-#define SOF_CS42L42_DAILINK(link1, link2, link3, link4, link5) \
-       ((((link1) | ((link2) << 3) | ((link3) << 6) | ((link4) << 9) | ((link5) << 12)) << SOF_CS42L42_DAILINK_SHIFT) & SOF_CS42L42_DAILINK_MASK)
 #define SOF_BT_OFFLOAD_PRESENT                 BIT(25)
 #define SOF_CS42L42_SSP_BT_SHIFT               26
 #define SOF_CS42L42_SSP_BT_MASK                        (GENMASK(28, 26))
 #define SOF_CS42L42_SSP_BT(quirk)      \
        (((quirk) << SOF_CS42L42_SSP_BT_SHIFT) & SOF_CS42L42_SSP_BT_MASK)
 
-enum {
-       LINK_NONE = 0,
-       LINK_HP = 1,
-       LINK_SPK = 2,
-       LINK_DMIC = 3,
-       LINK_HDMI = 4,
-       LINK_BT = 5,
-};
-
 static struct snd_soc_jack_pin jack_pins[] = {
        {
                .pin    = "Headphone Jack",
@@ -182,156 +169,63 @@ static struct snd_soc_dai_link_component cs42l42_component[] = {
        }
 };
 
-static struct snd_soc_dai_link *
-sof_card_dai_links_create(struct device *dev, enum sof_ssp_codec amp_type,
-                         int ssp_codec, int ssp_amp, int ssp_bt,
-                         int dmic_be_num, int hdmi_num, bool idisp_codec)
+static int
+sof_card_dai_links_create(struct device *dev, struct snd_soc_card *card,
+                         struct sof_card_private *ctx)
 {
-       struct snd_soc_dai_link *links;
        int ret;
-       int id = 0;
-       int link_seq;
-       int i;
-
-       links = devm_kcalloc(dev, sof_audio_card_cs42l42.num_links,
-                           sizeof(struct snd_soc_dai_link), GFP_KERNEL);
-       if (!links)
-               goto devm_err;
-
-       link_seq = (sof_cs42l42_quirk & SOF_CS42L42_DAILINK_MASK) >> SOF_CS42L42_DAILINK_SHIFT;
-
-       while (link_seq) {
-               int link_type = link_seq & 0x07;
-
-               switch (link_type) {
-               case LINK_HP:
-                       ret = sof_intel_board_set_codec_link(dev, &links[id], id,
-                                                            CODEC_CS42L42,
-                                                            ssp_codec);
-                       if (ret) {
-                               dev_err(dev, "fail to create hp codec dai links, ret %d\n",
-                                       ret);
-                               goto devm_err;
-                       }
-
-                       /* codec-specific fields */
-                       links[id].codecs = cs42l42_component;
-                       links[id].num_codecs = ARRAY_SIZE(cs42l42_component);
-                       links[id].init = sof_cs42l42_init;
-                       links[id].exit = sof_cs42l42_exit;
-                       links[id].ops = &sof_cs42l42_ops;
-
-                       id++;
-                       break;
-               case LINK_SPK:
-                       if (amp_type != CODEC_NONE) {
-                               ret = sof_intel_board_set_ssp_amp_link(dev,
-                                                                      &links[id],
-                                                                      id,
-                                                                      amp_type,
-                                                                      ssp_amp);
-                               if (ret) {
-                                       dev_err(dev, "fail to create spk amp dai links, ret %d\n",
-                                               ret);
-                                       goto devm_err;
-                               }
-
-                               /* codec-specific fields */
-                               switch (amp_type) {
-                               case CODEC_MAX98357A:
-                                       max_98357a_dai_link(&links[id]);
-                                       break;
-                               case CODEC_MAX98360A:
-                                       max_98360a_dai_link(&links[id]);
-                                       break;
-                               default:
-                                       dev_err(dev, "invalid amp type %d\n",
-                                               amp_type);
-                                       goto devm_err;
-                               }
-
-                               id++;
-                       }
-                       break;
-               case LINK_DMIC:
-                       if (dmic_be_num > 0) {
-                               /* at least we have dmic01 */
-                               ret = sof_intel_board_set_dmic_link(dev,
-                                                                   &links[id],
-                                                                   id,
-                                                                   SOF_DMIC_01);
-                               if (ret) {
-                                       dev_err(dev, "fail to create dmic01 link, ret %d\n",
-                                               ret);
-                                       goto devm_err;
-                               }
-
-                               id++;
-                       }
-
-                       if (dmic_be_num > 1) {
-                               /* set up 2 BE links at most */
-                               ret = sof_intel_board_set_dmic_link(dev,
-                                                                   &links[id],
-                                                                   id,
-                                                                   SOF_DMIC_16K);
-                               if (ret) {
-                                       dev_err(dev, "fail to create dmic16k link, ret %d\n",
-                                               ret);
-                                       goto devm_err;
-                               }
-
-                               id++;
-                       }
-                       break;
-               case LINK_HDMI:
-                       for (i = 1; i <= hdmi_num; i++) {
-                               ret = sof_intel_board_set_intel_hdmi_link(dev,
-                                                                         &links[id],
-                                                                         id, i,
-                                                                         idisp_codec);
-                               if (ret) {
-                                       dev_err(dev, "fail to create hdmi link, ret %d\n",
-                                               ret);
-                                       goto devm_err;
-                               }
-
-                               id++;
-                       }
-                       break;
-               case LINK_BT:
-                       if (sof_cs42l42_quirk & SOF_BT_OFFLOAD_PRESENT) {
-                               ret = sof_intel_board_set_bt_link(dev,
-                                                                 &links[id], id,
-                                                                 ssp_bt);
-                               if (ret) {
-                                       dev_err(dev, "fail to create bt offload dai links, ret %d\n",
-                                               ret);
-                                       goto devm_err;
-                               }
-
-                               id++;
-                       }
-                       break;
-               case LINK_NONE:
-                       /* caught here if it's not used as terminator in macro */
-               default:
-                       dev_err(dev, "invalid link type %d\n", link_type);
-                       goto devm_err;
-               }
-
-               link_seq >>= 3;
+
+       ret = sof_intel_board_set_dai_link(dev, card, ctx);
+       if (ret)
+               return ret;
+
+       if (!ctx->codec_link) {
+               dev_err(dev, "codec link not available");
+               return -EINVAL;
+       }
+
+       /* codec-specific fields for headphone codec */
+       ctx->codec_link->codecs = cs42l42_component;
+       ctx->codec_link->num_codecs = ARRAY_SIZE(cs42l42_component);
+       ctx->codec_link->init = sof_cs42l42_init;
+       ctx->codec_link->exit = sof_cs42l42_exit;
+       ctx->codec_link->ops = &sof_cs42l42_ops;
+
+       if (ctx->amp_type == CODEC_NONE)
+               return 0;
+
+       if (!ctx->amp_link) {
+               dev_err(dev, "amp link not available");
+               return -EINVAL;
        }
 
-       return links;
-devm_err:
-       return NULL;
+       /* codec-specific fields for speaker amplifier */
+       switch (ctx->amp_type) {
+       case CODEC_MAX98357A:
+               max_98357a_dai_link(ctx->amp_link);
+               break;
+       case CODEC_MAX98360A:
+               max_98360a_dai_link(ctx->amp_link);
+               break;
+       default:
+               dev_err(dev, "invalid amp type %d\n", ctx->amp_type);
+               return -EINVAL;
+       }
+
+       return 0;
 }
 
+#define GLK_LINK_ORDER SOF_LINK_ORDER(SOF_LINK_AMP,         \
+                                       SOF_LINK_CODEC,      \
+                                       SOF_LINK_DMIC01,     \
+                                       SOF_LINK_IDISP_HDMI, \
+                                       SOF_LINK_NONE,       \
+                                       SOF_LINK_NONE,       \
+                                       SOF_LINK_NONE)
+
 static int sof_audio_probe(struct platform_device *pdev)
 {
        struct snd_soc_acpi_mach *mach = pdev->dev.platform_data;
-       struct snd_soc_dai_link *dai_links;
        struct sof_card_private *ctx;
        int ret;
 
@@ -348,6 +242,9 @@ static int sof_audio_probe(struct platform_device *pdev)
        if (soc_intel_is_glk()) {
                ctx->dmic_be_num = 1;
                ctx->hdmi_num = 3;
+
+               /* overwrite the DAI link order for GLK boards */
+               ctx->link_order_overwrite = GLK_LINK_ORDER;
        } else {
                ctx->dmic_be_num = 2;
                ctx->hdmi_num = (sof_cs42l42_quirk & SOF_CS42L42_NUM_HDMIDEV_MASK) >>
@@ -371,25 +268,13 @@ static int sof_audio_probe(struct platform_device *pdev)
 
        ctx->ssp_codec = sof_cs42l42_quirk & SOF_CS42L42_SSP_CODEC_MASK;
 
-       /* compute number of dai links */
-       sof_audio_card_cs42l42.num_links = 1 + ctx->dmic_be_num + ctx->hdmi_num;
-
-       if (ctx->amp_type != CODEC_NONE)
-               sof_audio_card_cs42l42.num_links++;
-       if (sof_cs42l42_quirk & SOF_BT_OFFLOAD_PRESENT) {
+       if (sof_cs42l42_quirk & SOF_BT_OFFLOAD_PRESENT)
                ctx->bt_offload_present = true;
-               sof_audio_card_cs42l42.num_links++;
-       }
-
-       dai_links = sof_card_dai_links_create(&pdev->dev, ctx->amp_type,
-                                             ctx->ssp_codec, ctx->ssp_amp,
-                                             ctx->ssp_bt, ctx->dmic_be_num,
-                                             ctx->hdmi_num,
-                                             ctx->hdmi.idisp_codec);
-       if (!dai_links)
-               return -ENOMEM;
 
-       sof_audio_card_cs42l42.dai_link = dai_links;
+       /* update dai_link */
+       ret = sof_card_dai_links_create(&pdev->dev, &sof_audio_card_cs42l42, ctx);
+       if (ret)
+               return ret;
 
        sof_audio_card_cs42l42.dev = &pdev->dev;
 
@@ -409,14 +294,12 @@ static const struct platform_device_id board_ids[] = {
        {
                .name = "glk_cs4242_mx98357a",
                .driver_data = (kernel_ulong_t)(SOF_CS42L42_SSP_CODEC(2) |
-                                       SOF_CS42L42_SSP_AMP(1)) |
-                                       SOF_CS42L42_DAILINK(LINK_SPK, LINK_HP, LINK_DMIC, LINK_HDMI, LINK_NONE),
+                                       SOF_CS42L42_SSP_AMP(1)),
        },
        {
                .name = "jsl_cs4242_mx98360a",
                .driver_data = (kernel_ulong_t)(SOF_CS42L42_SSP_CODEC(0) |
-                                       SOF_CS42L42_SSP_AMP(1)) |
-                                       SOF_CS42L42_DAILINK(LINK_HP, LINK_DMIC, LINK_HDMI, LINK_SPK, LINK_NONE),
+                                       SOF_CS42L42_SSP_AMP(1)),
        },
        {
                .name = "adl_mx98360a_cs4242",
@@ -424,8 +307,7 @@ static const struct platform_device_id board_ids[] = {
                                SOF_CS42L42_SSP_AMP(1) |
                                SOF_CS42L42_NUM_HDMIDEV(4) |
                                SOF_BT_OFFLOAD_PRESENT |
-                               SOF_CS42L42_SSP_BT(2) |
-                               SOF_CS42L42_DAILINK(LINK_HP, LINK_DMIC, LINK_HDMI, LINK_SPK, LINK_BT)),
+                               SOF_CS42L42_SSP_BT(2)),
        },
        { }
 };