media: i2c: imx335: Improve configuration error reporting

The existing imx335_parse_hw_config function has two paths
that can be taken without reporting to the user the reason
for failing to accept the hardware configuration.

Extend the error reporting paths to identify failures when
probing the device.

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index af5262aa0a5042ada7c15ef18edd4e1a8293a26d..26aaa5048a8b47de0ce54dfa0589b0ff4ccce14f 100644 (file)
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -795,8 +795,10 @@ static int imx335_parse_hw_config(struct imx335 *imx335)
        }
 
        ep = fwnode_graph_get_next_endpoint(fwnode, NULL);
-       if (!ep)
+       if (!ep) {
+               dev_err(imx335->dev, "Failed to get next endpoint\n");
                return -ENXIO;
+       }
 
        ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
        fwnode_handle_put(ep);
@@ -821,6 +823,8 @@ static int imx335_parse_hw_config(struct imx335 *imx335)
                if (bus_cfg.link_frequencies[i] == IMX335_LINK_FREQ)
                        goto done_endpoint_free;
 
+       dev_err(imx335->dev, "no compatible link frequencies found\n");
+
        ret = -EINVAL;
 
 done_endpoint_free: