leds: tca6507: Use devm_led_classdev_register() to simplify remove path

Use devm version of LED classdev register add function to handle removal.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20231116224121.302150-2-afd@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 9a6af6d8b5b5da1bbf23f1c9c80fc2207b6601c5..4f22f42249467d7ce5a321a43affd490eb9598a9 100644 (file)
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -753,37 +753,25 @@ static int tca6507_probe(struct i2c_client *client)
                        l->led_cdev.brightness_set = tca6507_brightness_set;
                        l->led_cdev.blink_set = tca6507_blink_set;
                        l->bank = -1;
-                       err = led_classdev_register(dev, &l->led_cdev);
+                       err = devm_led_classdev_register(dev, &l->led_cdev);
                        if (err < 0)
-                               goto exit;
+                               return err;
                }
        }
        err = tca6507_probe_gpios(dev, tca, pdata);
        if (err)
-               goto exit;
+               return err;
        /* set all registers to known state - zero */
        tca->reg_set = 0x7f;
        schedule_work(&tca->work);
 
        return 0;
-exit:
-       while (i--) {
-               if (tca->leds[i].led_cdev.name)
-                       led_classdev_unregister(&tca->leds[i].led_cdev);
-       }
-       return err;
 }
 
 static void tca6507_remove(struct i2c_client *client)
 {
-       int i;
        struct tca6507_chip *tca = i2c_get_clientdata(client);
-       struct tca6507_led *tca_leds = tca->leds;
 
-       for (i = 0; i < NUM_LEDS; i++) {
-               if (tca_leds[i].led_cdev.name)
-                       led_classdev_unregister(&tca_leds[i].led_cdev);
-       }
        cancel_work_sync(&tca->work);
 }