perf hisi-ptt: Fix one memory leakage in hisi_ptt_process_auxtrace_event()
authorYicong Yang <yangyicong@hisilicon.com>
Thu, 7 Dec 2023 08:16:35 +0000 (16:16 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 13 Dec 2023 16:56:09 +0000 (13:56 -0300)
ASan complains a memory leakage in hisi_ptt_process_auxtrace_event()
that the data buffer is not freed. Since currently we only support the
raw dump trace mode, the data buffer is used only within this function.
So fix this by freeing the data buffer before going out.

Fixes: 5e91e57e68090c0e ("perf auxtrace arm64: Add support for parsing HiSilicon PCIe Trace packet")
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Acked-by: Namhyung Kim <Namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>
Cc: Junhao He <hejunhao3@huawei.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qi Liu <liuqi115@huawei.com>
Link: https://lore.kernel.org/r/20231207081635.8427-3-yangyicong@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/hisi-ptt.c

index 43bd1ca62d58244583f8c8f742d890c79b6e7b36..52d0ce302ca042ed0bae720273443d3f2794affb 100644 (file)
@@ -123,6 +123,7 @@ static int hisi_ptt_process_auxtrace_event(struct perf_session *session,
        if (dump_trace)
                hisi_ptt_dump_event(ptt, data, size);
 
+       free(data);
        return 0;
 }