iio: adc: imx7d_adc: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20211008092858.495-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/imx7d_adc.c b/drivers/iio/adc/imx7d_adc.c
index 4969a5f941e33a3569b83030dfa48ce36a47120d..092f8d29652733b872cb10b119252f1246b0cba7 100644 (file)
--- a/drivers/iio/adc/imx7d_adc.c
+++ b/drivers/iio/adc/imx7d_adc.c
@@ -493,22 +493,16 @@ static int imx7d_adc_probe(struct platform_device *pdev)
 
        irq = platform_get_irq(pdev, 0);
        if (irq < 0)
-               return irq;
+               return dev_err_probe(dev, irq, "Failed getting irq\n");
 
        info->clk = devm_clk_get(dev, "adc");
-       if (IS_ERR(info->clk)) {
-               ret = PTR_ERR(info->clk);
-               dev_err(dev, "Failed getting clock, err = %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(info->clk))
+               return dev_err_probe(dev, PTR_ERR(info->clk), "Failed getting clock\n");
 
        info->vref = devm_regulator_get(dev, "vref");
-       if (IS_ERR(info->vref)) {
-               ret = PTR_ERR(info->vref);
-               dev_err(dev,
-                       "Failed getting reference voltage, err = %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(info->vref))
+               return dev_err_probe(dev, PTR_ERR(info->vref),
+                                    "Failed getting reference voltage\n");
 
        platform_set_drvdata(pdev, indio_dev);