thermal/drivers/rcar_gen3_thermal: Do not call set_trips() when resuming
authorNiklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Wed, 8 Feb 2023 19:03:31 +0000 (20:03 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 15 Feb 2023 16:29:07 +0000 (17:29 +0100)
There is no need to explicitly call set_trips() when resuming from
suspend. The thermal framework calls thermal_zone_device_update() that
restores the trip points.

Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20230208190333.3159879-2-niklas.soderlund+renesas@ragnatech.se
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/rcar_gen3_thermal.c

index 04245393e78d02c5d7995e18616fb464d84e4518..1895d77f586f7202921455f906cc9255ef53f253 100644 (file)
@@ -560,12 +560,8 @@ static int __maybe_unused rcar_gen3_thermal_resume(struct device *dev)
 
        for (i = 0; i < priv->num_tscs; i++) {
                struct rcar_gen3_thermal_tsc *tsc = priv->tscs[i];
-               struct thermal_zone_device *zone = tsc->zone;
 
                priv->thermal_init(tsc);
-               if (zone->ops->set_trips)
-                       rcar_gen3_thermal_set_trips(zone, zone->prev_low_trip,
-                                                   zone->prev_high_trip);
        }
 
        return 0;