tls: rx: assume crypto always calls our callback
authorJakub Kicinski <kuba@kernel.org>
Mon, 11 Apr 2022 19:19:12 +0000 (12:19 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 13 Apr 2022 10:45:39 +0000 (11:45 +0100)
If crypto didn't always invoke our callback for async
we'd not be clearing skb->sk and would crash in the
skb core when freeing it. This if must be dead code.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c

index d0b7078ca3ec935345f1158b5cdf2db412b7b861..fd1a7ccc22bb72f02d1ddd15760f60318c69086a 100644 (file)
@@ -268,9 +268,6 @@ static int tls_do_decryption(struct sock *sk,
        if (ret == -EBADMSG)
                TLS_INC_STATS(sock_net(sk), LINUX_MIB_TLSDECRYPTERROR);
 
-       if (async)
-               atomic_dec(&ctx->decrypt_pending);
-
        return ret;
 }