mm: hugetlb_vmemmap: remove redundant list_del()
authorMuchun Song <songmuchun@bytedance.com>
Thu, 27 Oct 2022 03:36:41 +0000 (11:36 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Wed, 30 Nov 2022 23:58:40 +0000 (15:58 -0800)
The ->lru field will be assigned to a new value in __free_page().  So it
is unnecessary to delete it from the @list.  Just remove it to simplify
the code.

Link: https://lkml.kernel.org/r/20221027033641.66709-1-songmuchun@bytedance.com
Signed-off-by: Muchun Song <songmuchun@bytedance.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/hugetlb_vmemmap.c

index 4962dd1ba4a680a1c9cca118bf8dc7908be9a78a..7898c2c75e351dd4ffe778ea54c176ee83dce037 100644 (file)
@@ -232,10 +232,8 @@ static void free_vmemmap_page_list(struct list_head *list)
 {
        struct page *page, *next;
 
-       list_for_each_entry_safe(page, next, list, lru) {
-               list_del(&page->lru);
+       list_for_each_entry_safe(page, next, list, lru)
                free_vmemmap_page(page);
-       }
 }
 
 static void vmemmap_remap_pte(pte_t *pte, unsigned long addr,