mtd: rawnand: atmel: Warn about failure to unregister mtd device

The Linux device core doesn't intend remove callbacks to fail. If an
error code is returned the device is removed anyhow. So wail loudly if
the atmel specific remove callback fails and return 0 anyhow to suppress
the generic (and little helpful) error message by the device core.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220607062503.211345-1-u.kleine-koenig@pengutronix.de

diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c
index 6ef14442c71a08e16739da994c5e37f317cb44f9..c9ac3baf68c0258c20d5ecbd31d43dff6dda5cfd 100644 (file)
--- a/drivers/mtd/nand/raw/atmel/nand-controller.c
+++ b/drivers/mtd/nand/raw/atmel/nand-controller.c
@@ -2629,7 +2629,9 @@ static int atmel_nand_controller_remove(struct platform_device *pdev)
 {
        struct atmel_nand_controller *nc = platform_get_drvdata(pdev);
 
-       return nc->caps->ops->remove(nc);
+       WARN_ON(nc->caps->ops->remove(nc));
+
+       return 0;
 }
 
 static __maybe_unused int atmel_nand_controller_resume(struct device *dev)