xfs: Replace function declaration by actual definition
authorPavel Reichl <preichl@redhat.com>
Wed, 13 Nov 2019 01:04:27 +0000 (17:04 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Thu, 14 Nov 2019 02:22:40 +0000 (18:22 -0800)
Signed-off-by: Pavel Reichl <preichl@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
[darrick: fix typo in subject line]
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_qm_syscalls.c

index e685b9ae90b9735fa1e0f6e8efc7b8fdfcc9129c..1ea82764bf897b41beb15bd5b14fa5f6a924fdf6 100644 (file)
 #include "xfs_qm.h"
 #include "xfs_icache.h"
 
-STATIC int xfs_qm_log_quotaoff(struct xfs_mount *mp,
-                                       struct xfs_qoff_logitem **qoffstartp,
-                                       uint flags);
-STATIC int xfs_qm_log_quotaoff_end(struct xfs_mount *mp,
-                                       struct xfs_qoff_logitem *startqoff,
-                                       uint flags);
+STATIC int
+xfs_qm_log_quotaoff(
+       struct xfs_mount        *mp,
+       struct xfs_qoff_logitem **qoffstartp,
+       uint                    flags)
+{
+       struct xfs_trans        *tp;
+       int                     error;
+       struct xfs_qoff_logitem *qoffi;
+
+       *qoffstartp = NULL;
+
+       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_quotaoff, 0, 0, 0, &tp);
+       if (error)
+               goto out;
+
+       qoffi = xfs_trans_get_qoff_item(tp, NULL, flags & XFS_ALL_QUOTA_ACCT);
+       xfs_trans_log_quotaoff_item(tp, qoffi);
+
+       spin_lock(&mp->m_sb_lock);
+       mp->m_sb.sb_qflags = (mp->m_qflags & ~(flags)) & XFS_MOUNT_QUOTA_ALL;
+       spin_unlock(&mp->m_sb_lock);
+
+       xfs_log_sb(tp);
+
+       /*
+        * We have to make sure that the transaction is secure on disk before we
+        * return and actually stop quota accounting. So, make it synchronous.
+        * We don't care about quotoff's performance.
+        */
+       xfs_trans_set_sync(tp);
+       error = xfs_trans_commit(tp);
+       if (error)
+               goto out;
+
+       *qoffstartp = qoffi;
+out:
+       return error;
+}
+
+STATIC int
+xfs_qm_log_quotaoff_end(
+       struct xfs_mount        *mp,
+       struct xfs_qoff_logitem *startqoff,
+       uint                    flags)
+{
+       struct xfs_trans        *tp;
+       int                     error;
+       struct xfs_qoff_logitem *qoffi;
+
+       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_equotaoff, 0, 0, 0, &tp);
+       if (error)
+               return error;
+
+       qoffi = xfs_trans_get_qoff_item(tp, startqoff,
+                                       flags & XFS_ALL_QUOTA_ACCT);
+       xfs_trans_log_quotaoff_item(tp, qoffi);
+
+       /*
+        * We have to make sure that the transaction is secure on disk before we
+        * return and actually stop quota accounting. So, make it synchronous.
+        * We don't care about quotoff's performance.
+        */
+       xfs_trans_set_sync(tp);
+       return xfs_trans_commit(tp);
+}
 
 /*
  * Turn off quota accounting and/or enforcement for all udquots and/or
@@ -541,74 +601,6 @@ out_unlock:
        return error;
 }
 
-STATIC int
-xfs_qm_log_quotaoff_end(
-       struct xfs_mount        *mp,
-       struct xfs_qoff_logitem *startqoff,
-       uint                    flags)
-{
-       struct xfs_trans        *tp;
-       int                     error;
-       struct xfs_qoff_logitem *qoffi;
-
-       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_equotaoff, 0, 0, 0, &tp);
-       if (error)
-               return error;
-
-       qoffi = xfs_trans_get_qoff_item(tp, startqoff,
-                                       flags & XFS_ALL_QUOTA_ACCT);
-       xfs_trans_log_quotaoff_item(tp, qoffi);
-
-       /*
-        * We have to make sure that the transaction is secure on disk before we
-        * return and actually stop quota accounting. So, make it synchronous.
-        * We don't care about quotoff's performance.
-        */
-       xfs_trans_set_sync(tp);
-       return xfs_trans_commit(tp);
-}
-
-
-STATIC int
-xfs_qm_log_quotaoff(
-       struct xfs_mount        *mp,
-       struct xfs_qoff_logitem **qoffstartp,
-       uint                    flags)
-{
-       struct xfs_trans        *tp;
-       int                     error;
-       struct xfs_qoff_logitem *qoffi;
-
-       *qoffstartp = NULL;
-
-       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_qm_quotaoff, 0, 0, 0, &tp);
-       if (error)
-               goto out;
-
-       qoffi = xfs_trans_get_qoff_item(tp, NULL, flags & XFS_ALL_QUOTA_ACCT);
-       xfs_trans_log_quotaoff_item(tp, qoffi);
-
-       spin_lock(&mp->m_sb_lock);
-       mp->m_sb.sb_qflags = (mp->m_qflags & ~(flags)) & XFS_MOUNT_QUOTA_ALL;
-       spin_unlock(&mp->m_sb_lock);
-
-       xfs_log_sb(tp);
-
-       /*
-        * We have to make sure that the transaction is secure on disk before we
-        * return and actually stop quota accounting. So, make it synchronous.
-        * We don't care about quotoff's performance.
-        */
-       xfs_trans_set_sync(tp);
-       error = xfs_trans_commit(tp);
-       if (error)
-               goto out;
-
-       *qoffstartp = qoffi;
-out:
-       return error;
-}
-
 /* Fill out the quota context. */
 static void
 xfs_qm_scall_getquota_fill_qc(