RDMA/rxe: Remove the is_user members of struct rxe_sq/rxe_rq/rxe_srq
authorXiao Yang <yangx.jy@fujitsu.com>
Thu, 30 Sep 2021 09:48:10 +0000 (17:48 +0800)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 6 Oct 2021 22:45:29 +0000 (19:45 -0300)
The is_user members of struct rxe_sq/rxe_rq/rxe_srq are unsed since
commit ae6e843fe08d ("RDMA/rxe: Add memory barriers to kernel queues").
In this case, it is fine to remove them directly.

Link: https://lore.kernel.org/r/20210930094813.226888-2-yangx.jy@fujitsu.com
Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/sw/rxe/rxe_qp.c
drivers/infiniband/sw/rxe/rxe_srq.c
drivers/infiniband/sw/rxe/rxe_verbs.c
drivers/infiniband/sw/rxe/rxe_verbs.h

index c8f4790083d2350f1883159dfc2d42dbb7ad7190..975321812c870ff544c39a560ed7dd6a8d6ffc06 100644 (file)
@@ -307,8 +307,6 @@ static int rxe_qp_init_resp(struct rxe_dev *rxe, struct rxe_qp *qp,
        spin_lock_init(&qp->rq.producer_lock);
        spin_lock_init(&qp->rq.consumer_lock);
 
-       qp->rq.is_user = qp->is_user;
-
        skb_queue_head_init(&qp->resp_pkts);
 
        rxe_init_task(rxe, &qp->resp.task, qp,
index a9e7817e27325a92de62457e427801535cb41c3c..eb1c4c3b3a7865204b3c769aaac655a414ff0d2b 100644 (file)
@@ -86,7 +86,6 @@ int rxe_srq_from_init(struct rxe_dev *rxe, struct rxe_srq *srq,
        srq->srq_num            = srq->pelem.index;
        srq->rq.max_wr          = init->attr.max_wr;
        srq->rq.max_sge         = init->attr.max_sge;
-       srq->rq.is_user         = srq->is_user;
 
        srq_wqe_size            = rcv_wqe_size(srq->rq.max_sge);
 
index 9d0bb9aa751437f82df77b2d572e38950af156f1..c49ba03819647fb8e16fded1030577ee21a0e984 100644 (file)
@@ -267,9 +267,6 @@ static int rxe_create_srq(struct ib_srq *ibsrq, struct ib_srq_init_attr *init,
                if (udata->outlen < sizeof(*uresp))
                        return -EINVAL;
                uresp = udata->outbuf;
-               srq->is_user = true;
-       } else {
-               srq->is_user = false;
        }
 
        err = rxe_srq_chk_attr(rxe, NULL, &init->attr, IB_SRQ_INIT_MASK);
index c807639435ebe497b6c8bf26a623dd0872476092..962bb2481a284359666f36f882912494d0d9c707 100644 (file)
@@ -77,7 +77,6 @@ enum wqe_state {
 };
 
 struct rxe_sq {
-       bool                    is_user;
        int                     max_wr;
        int                     max_sge;
        int                     max_inline;
@@ -86,7 +85,6 @@ struct rxe_sq {
 };
 
 struct rxe_rq {
-       bool                    is_user;
        int                     max_wr;
        int                     max_sge;
        spinlock_t              producer_lock; /* guard queue producer */
@@ -100,7 +98,6 @@ struct rxe_srq {
        struct rxe_pd           *pd;
        struct rxe_rq           rq;
        u32                     srq_num;
-       bool                    is_user;
 
        int                     limit;
        int                     error;