NFSv4.1: don't retry BIND_CONN_TO_SESSION on session error
authorOlga Kornievskaia <kolga@netapp.com>
Thu, 24 Mar 2022 14:38:42 +0000 (10:38 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Thu, 24 Mar 2022 16:06:07 +0000 (12:06 -0400)
There is no reason to retry the operation if a session error had
occurred in such case result structure isn't filled out.

Fixes: dff58530c4ca ("NFSv4.1: fix handling of backchannel binding in BIND_CONN_TO_SESSION")
Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
fs/nfs/nfs4proc.c

index dd7a4c2a3f05a44521f83f4dab122b19a149d21f..e3f5b380cefe95e39ddf0151bdabc3004a27b544 100644 (file)
@@ -8340,6 +8340,7 @@ nfs4_bind_one_conn_to_session_done(struct rpc_task *task, void *calldata)
        case -NFS4ERR_DEADSESSION:
                nfs4_schedule_session_recovery(clp->cl_session,
                                task->tk_status);
+               return;
        }
        if (args->dir == NFS4_CDFC4_FORE_OR_BOTH &&
                        res->dir != NFS4_CDFS4_BOTH) {