drm: bridge: adv7511: fix CEC power down control register offset

The ADV7511_REG_CEC_CTRL = 0xE2 register is part of the main register
map - not the CEC register map. As such, we shouldn't apply an offset to
the register address. Doing so will cause us to address a bogus register
for chips with a CEC register map offset (e.g. ADV7533).

Fixes: 3b1b975003e4 ("drm: adv7511/33: add HDMI CEC support")
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220612144854.2223873-2-alvin@pqrs.dk

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h
index a031a0cd1f181022e193d9d4cc6a26ea343082a0..94de73cbeb2ddd893652e947648360e838a61ebe 100644 (file)
--- a/drivers/gpu/drm/bridge/adv7511/adv7511.h
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h
@@ -394,10 +394,7 @@ void adv7511_cec_irq_process(struct adv7511 *adv7511, unsigned int irq1);
 #else
 static inline int adv7511_cec_init(struct device *dev, struct adv7511 *adv7511)
 {
-       unsigned int offset = adv7511->type == ADV7533 ?
-                                               ADV7533_REG_CEC_OFFSET : 0;
-
-       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL + offset,
+       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL,
                     ADV7511_CEC_CTRL_POWER_DOWN);
        return 0;
 }

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
index 0b266f28f150f980ec6c514fe08010ecaa217cca..99964f5a5457b7f402ee27f325a43b1cd267da6a 100644 (file)
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c
@@ -359,7 +359,7 @@ int adv7511_cec_init(struct device *dev, struct adv7511 *adv7511)
                goto err_cec_alloc;
        }
 
-       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL + offset, 0);
+       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL, 0);
        /* cec soft reset */
        regmap_write(adv7511->regmap_cec,
                     ADV7511_REG_CEC_SOFT_RESET + offset, 0x01);
@@ -386,7 +386,7 @@ err_cec_alloc:
        dev_info(dev, "Initializing CEC failed with error %d, disabling CEC\n",
                 ret);
 err_cec_parse_dt:
-       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL + offset,
+       regmap_write(adv7511->regmap, ADV7511_REG_CEC_CTRL,
                     ADV7511_CEC_CTRL_POWER_DOWN);
        return ret == -EPROBE_DEFER ? ret : 0;
 }