drm/drm_file: fix use of uninitialized variable
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 3 Nov 2023 13:14:03 +0000 (15:14 +0200)
committerTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Thu, 7 Dec 2023 07:21:43 +0000 (09:21 +0200)
smatch reports:

drivers/gpu/drm/drm_file.c:967 drm_show_memory_stats() error: uninitialized symbol 'supported_status'.

'supported_status' is only set in one code path. I'm not familiar with
the code to say if that path will always be ran in real life, but
whether that is the case or not, I think it is good to initialize
'supported_status' to 0 to silence the warning (and possibly fix a bug).

Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231103-uninit-fixes-v2-1-c22b2444f5f5@ideasonboard.com
drivers/gpu/drm/drm_file.c

index 987c1a5d1773b35aaf720c5d351798aa1ba41d69..8c87287c3e16800369d6a5e79acde5d9168c146c 100644 (file)
@@ -898,7 +898,7 @@ void drm_show_memory_stats(struct drm_printer *p, struct drm_file *file)
 {
        struct drm_gem_object *obj;
        struct drm_memory_stats status = {};
-       enum drm_gem_object_status supported_status;
+       enum drm_gem_object_status supported_status = 0;
        int id;
 
        spin_lock(&file->table_lock);