parport: mfc3: avoid empty-body warning
authorArnd Bergmann <arnd@arndb.de>
Fri, 5 Apr 2024 14:42:57 +0000 (16:42 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Apr 2024 13:14:10 +0000 (15:14 +0200)
on m68k builds, the mfc3 driver causes a warning about an empty if() block:

drivers/parport/parport_mfc3.c: In function 'control_pc_to_mfc3':
drivers/parport/parport_mfc3.c:106:37: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]

Remove it in favor of a simpler comment.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Link: https://lore.kernel.org/lkml/20230727122448.2479942-1-arnd@kernel.org/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://lore.kernel.org/r/20240405144304.1223160-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/parport/parport_mfc3.c

index f4d0da741e8566a77fe1a15441d7bc6fec16eac4..bb1817218d7b222a25060f98a51aa2fd47f6f3fe 100644 (file)
@@ -102,8 +102,7 @@ static unsigned char control_pc_to_mfc3(unsigned char control)
                ret |= 128;
        if (control & PARPORT_CONTROL_AUTOFD) /* AUTOLF */
                ret &= ~64;
-       if (control & PARPORT_CONTROL_STROBE) /* Strobe */
-               /* Handled directly by hardware */;
+       /* PARPORT_CONTROL_STROBE handled directly by hardware */
        return ret;
 }