spi: spi-rspi: Drop redeclaring ret variable in qspi_transfer_in()
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Thu, 18 Nov 2021 03:10:41 +0000 (03:10 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 18 Nov 2021 13:57:55 +0000 (13:57 +0000)
"ret" variable is already declared in qspi_transfer_in() at the
beginning of function, drop redeclaring ret in the if block, fixing
below:

spi-rspi.c: In function ‘qspi_transfer_in’:
spi-rspi.c:838:7: warning: declaration of ‘ret’ shadows a previous local
  838 |   int ret = rspi_dma_transfer(rspi, NULL, &xfer->rx_sg);
      |       ^~~
spi-rspi.c:835:6: note: shadowed declaration is here
  835 |  int ret;

Fixes: db30083813b55 ("spi: rspi: avoid uninitialized variable access")
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20211118031041.2312-4-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-rspi.c

index b7df49a57e5fcfb5b37d8bf43e833d457529f0ef..bd5708d7e5a15b7bbc079d9b9416b48fe8f7bcc3 100644 (file)
@@ -835,7 +835,7 @@ static int qspi_transfer_in(struct rspi_data *rspi, struct spi_transfer *xfer)
        int ret;
 
        if (rspi->ctlr->can_dma && __rspi_can_dma(rspi, xfer)) {
-               int ret = rspi_dma_transfer(rspi, NULL, &xfer->rx_sg);
+               ret = rspi_dma_transfer(rspi, NULL, &xfer->rx_sg);
                if (ret != -EAGAIN)
                        return ret;
        }