memory: tegra: Make use of the helper function devm_add_action_or_reset()
authorCai Huoqing <caihuoqing@baidu.com>
Wed, 22 Sep 2021 13:00:01 +0000 (21:00 +0800)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Fri, 24 Sep 2021 11:18:47 +0000 (13:18 +0200)
Use devm_add_action_or_reset() instead of devm_add_action() to simplify
the error handling.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210922130002.586-1-caihuoqing@baidu.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
drivers/memory/tegra/mc.c

index 6b710c204799f7d9c35e522888bef293bc1e2aa9..44b4a4080920ea48230e3d2abbdbd34247eb0238 100644 (file)
@@ -87,11 +87,9 @@ struct tegra_mc *devm_tegra_memory_controller_get(struct device *dev)
                return ERR_PTR(-EPROBE_DEFER);
        }
 
-       err = devm_add_action(dev, tegra_mc_devm_action_put_device, mc);
-       if (err) {
-               put_device(mc->dev);
+       err = devm_add_action_or_reset(dev, tegra_mc_devm_action_put_device, mc);
+       if (err)
                return ERR_PTR(err);
-       }
 
        return mc;
 }