scsi: ufs: core: Only suspend clock scaling if scaling down
authorPeter Wang <peter.wang@mediatek.com>
Thu, 31 Aug 2023 13:08:24 +0000 (21:08 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 13 Oct 2023 17:16:09 +0000 (13:16 -0400)
If clock scale up and suspend clock scaling, ufs will keep high
performance/power mode but no read/write requests on going.  It is logic
wrong and have power concern.

Signed-off-by: Peter Wang <peter.wang@mediatek.com>
Link: https://lore.kernel.org/r/20230831130826.5592-2-peter.wang@mediatek.com
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/ufs/core/ufshcd.c

index c45737c5adb90533adb00ab93a559c631d8f6fce..c6c53bdd3e4307d56885871193efe4f29c1bf5a1 100644 (file)
@@ -1430,7 +1430,7 @@ static int ufshcd_devfreq_target(struct device *dev,
                ktime_to_us(ktime_sub(ktime_get(), start)), ret);
 
 out:
-       if (sched_clk_scaling_suspend_work)
+       if (sched_clk_scaling_suspend_work && !scale_up)
                queue_work(hba->clk_scaling.workq,
                           &hba->clk_scaling.suspend_work);