drm: mxsfb: Set fallback bus format when the bridge doesn't provide one

If a bridge doesn't do any bus format handling MEDIA_BUS_FMT_FIXED is
returned. Fallback to a reasonable default (MEDIA_BUS_FMT_RGB888_1X24) in
that case.

This unbreaks e.g. using mxsfb with the nwl bridge and mipi dsi panels.

Reported-by: Martin Kepplinger <martink@posteo.de>
Signed-off-by: Guido Günther <agx@sigxcpu.org>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Stefan Agner <stefan@agner.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/781f0352052cc50c823c199ef5f53c84902d0580.1633959458.git.agx@sigxcpu.org

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
index d1cab1166ecf30d781dbc998c854dbaddfff4100..0655582ae8ed64f2e7eb822a229f69b992aae69a 100644 (file)
--- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c
@@ -362,6 +362,12 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc,
                        drm_atomic_get_new_bridge_state(state,
                                                        mxsfb->bridge);
                bus_format = bridge_state->input_bus_cfg.format;
+               if (bus_format == MEDIA_BUS_FMT_FIXED) {
+                       dev_warn_once(drm->dev,
+                                     "Bridge does not provide bus format, assuming MEDIA_BUS_FMT_RGB888_1X24.\n"
+                                     "Please fix bridge driver by handling atomic_get_input_bus_fmts.\n");
+                       bus_format = MEDIA_BUS_FMT_RGB888_1X24;
+               }
        }
 
        /* If there is no bridge, use bus format from connector */