scsi: libsas: Add missing annotation for sas_ata_qc_issue()
authorJules Irenge <jbi.octave@gmail.com>
Sat, 11 Apr 2020 00:19:30 +0000 (01:19 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 15 Apr 2020 01:46:15 +0000 (21:46 -0400)
Sparse reports a warning at sas_ata_qc_issue()

warning: context imbalance in sas_ata_qc_issue() - unexpected unlock
The root cause is the missing annotation at sas_ata_qc_issue()

Add the missing __must_hold(ap->lock) annotation

Link: https://lore.kernel.org/r/20200411001933.10072-7-jbi.octave@gmail.com
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_ata.c

index c5a828a041e07ea88747f574fd10aef4e3bd4cd8..5d716d38870718df5f5ea877a01e9cf577dd0ed7 100644 (file)
@@ -160,6 +160,7 @@ qc_already_gone:
 }
 
 static unsigned int sas_ata_qc_issue(struct ata_queued_cmd *qc)
+       __must_hold(ap->lock)
 {
        struct sas_task *task;
        struct scatterlist *sg;