Staging: vc04_services: Fix unsigned int warnings
authorBaidyanath Kundu <kundubaidya99@gmail.com>
Mon, 13 Jul 2020 14:36:53 +0000 (20:06 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Jul 2020 14:03:32 +0000 (16:03 +0200)
This patch fixes the checkpatch.pl warning:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
Link: https://lore.kernel.org/r/20200713143653.32332-1-kundubaidya99@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c
drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c

index 8c9ddd86fbbd762c9babffdf8d28d6aa51135a1e..292fcee9d6f2d9e645b61d4dae9c412840be7f5e 100644 (file)
@@ -9,7 +9,7 @@
 
 struct bcm2835_audio_instance {
        struct device *dev;
-       unsigned service_handle;
+       unsigned int service_handle;
        struct completion msg_avail_comp;
        struct mutex vchi_mutex;
        struct bcm2835_alsa_stream *alsa_stream;
@@ -91,7 +91,7 @@ static int bcm2835_audio_send_simple(struct bcm2835_audio_instance *instance,
 
 static enum vchiq_status audio_vchi_callback(enum vchiq_reason reason,
                                             struct vchiq_header *header,
-                                            unsigned handle, void *userdata)
+                                            unsigned int handle, void *userdata)
 {
        struct bcm2835_audio_instance *instance = vchiq_get_service_userdata(handle);
        struct vc_audio_msg *m;
index cb9ef9a4150b30e96c844396bec3f30b3ee5f723..18d63df368c480b1a1ef3f1b023e96284ca403bb 100644 (file)
@@ -84,11 +84,11 @@ extern enum vchiq_status vchiq_open_service(struct vchiq_instance *instance,
 extern enum vchiq_status vchiq_close_service(unsigned int service);
 extern enum vchiq_status vchiq_use_service(unsigned int service);
 extern enum vchiq_status vchiq_release_service(unsigned int service);
-extern void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header);
+extern void vchiq_msg_queue_push(unsigned int handle, struct vchiq_header *header);
 extern void           vchiq_release_message(unsigned int service,
        struct vchiq_header *header);
-extern int vchiq_queue_kernel_message(unsigned handle, void *data,
-                                     unsigned size);
+extern int vchiq_queue_kernel_message(unsigned int handle, void *data,
+                                     unsigned int size);
 extern enum vchiq_status vchiq_bulk_transmit(unsigned int service,
        const void *data, unsigned int size, void *userdata,
        enum vchiq_bulk_mode mode);
@@ -98,6 +98,6 @@ extern enum vchiq_status vchiq_bulk_receive(unsigned int service,
 extern void *vchiq_get_service_userdata(unsigned int service);
 extern enum vchiq_status vchiq_get_peer_version(unsigned int handle,
       short *peer_version);
-extern struct vchiq_header *vchiq_msg_hold(unsigned handle);
+extern struct vchiq_header *vchiq_msg_hold(unsigned int handle);
 
 #endif /* VCHIQ_H */
index 1bc4ce5776143e449b224de4aae3321d83fc7591..af64cde82d363fc2791c6972c8184c217098431c 100644 (file)
@@ -2275,7 +2275,7 @@ fail_free_handler_thread:
        return VCHIQ_ERROR;
 }
 
-void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header)
+void vchiq_msg_queue_push(unsigned int handle, struct vchiq_header *header)
 {
        struct vchiq_service *service = find_service_by_handle(handle);
        int pos;
@@ -2293,7 +2293,7 @@ void vchiq_msg_queue_push(unsigned handle, struct vchiq_header *header)
 }
 EXPORT_SYMBOL(vchiq_msg_queue_push);
 
-struct vchiq_header *vchiq_msg_hold(unsigned handle)
+struct vchiq_header *vchiq_msg_hold(unsigned int handle)
 {
        struct vchiq_service *service = find_service_by_handle(handle);
        struct vchiq_header *header;
@@ -3214,7 +3214,7 @@ error_exit:
        return status;
 }
 
-int vchiq_queue_kernel_message(unsigned handle, void *data, unsigned size)
+int vchiq_queue_kernel_message(unsigned int handle, void *data, unsigned int size)
 {
        enum vchiq_status status;
 
index a075cd63da7fd52e5e6ca9cfef8fb8579bbc4fe0..dc767730db430d3038bd46718e14a8ccedc7a5b2 100644 (file)
@@ -163,7 +163,7 @@ struct mmal_msg_context {
 };
 
 struct vchiq_mmal_instance {
-       unsigned service_handle;
+       unsigned int service_handle;
 
        /* ensure serialised access to service */
        struct mutex vchiq_mutex;
@@ -548,7 +548,7 @@ static void bulk_abort_cb(struct vchiq_mmal_instance *instance,
 /* incoming event service callback */
 static enum vchiq_status service_callback(enum vchiq_reason reason,
                                          struct vchiq_header *header,
-                                         unsigned handle, void *bulk_ctx)
+                                         unsigned int handle, void *bulk_ctx)
 {
        struct vchiq_mmal_instance *instance = vchiq_get_service_userdata(handle);
        u32 msg_len;