ALSA: emu10k1: prune vestiges of SNDRV_SFNT_SAMPLE_{BIDIR,REVERSE}_LOOP support

This is required only to implement WAVE_BIDIR_LOOP and WAVE_LOOP_BACK in
the GUS patch loader. It has not worked on emu10k1 since before ALSA hit
mainline, yet nobody appears to have complained. And as it isn't super
easy to implement, just admit defeat and clean up the code.

If somebody wanted to resurrect the feature, the emu8k driver could
serve as a template, but the code would be quite different. But
arguably, this should be done in user space in the first place, as this
doesn't represent a hardware feature (somewhat ironically, the actual
GUS driver has no synth support, and therefore no GUS patch loader).

Note that instead of properly rejecting affected samples, we continue to
just pretend that the feature wasn't requested. This is extremely
questionable behavior, but avoids that possibly unused instruments
suddenly prevent loading the entire file, which would break backwards
compatibility. But at least we log a warning now.

Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Message-ID: <20240406064830.1029573-6-oswald.buddenhagen@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/sound/pci/emu10k1/emu10k1_patch.c b/sound/pci/emu10k1/emu10k1_patch.c
index 89890f24509f0312183e445782070f56ea81c01a..49214c22680847815b0c41ba8006cc825dc463a5 100644 (file)
--- a/sound/pci/emu10k1/emu10k1_patch.c
+++ b/sound/pci/emu10k1/emu10k1_patch.c
@@ -28,8 +28,6 @@ snd_emu10k1_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp,
 {
        int offset;
        int truesize, size, blocksize;
-       __maybe_unused int loopsize;
-       int loopend, sampleend;
        unsigned int start_addr;
        struct snd_emu10k1 *emu;
 
@@ -43,32 +41,24 @@ snd_emu10k1_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp,
                return 0;
        }
 
+       if (sp->v.mode_flags & (SNDRV_SFNT_SAMPLE_BIDIR_LOOP | SNDRV_SFNT_SAMPLE_REVERSE_LOOP)) {
+               /* should instead return -ENOTSUPP; but compatibility */
+               printk(KERN_WARNING "Emu10k1 wavetable patch %d with unsupported loop feature\n",
+                      sp->v.sample);
+       }
+
        /* recalculate address offset */
        sp->v.end -= sp->v.start;
        sp->v.loopstart -= sp->v.start;
        sp->v.loopend -= sp->v.start;
        sp->v.start = 0;
 
-       /* some samples have invalid data.  the addresses are corrected in voice info */
-       sampleend = sp->v.end;
-       if (sampleend > sp->v.size)
-               sampleend = sp->v.size;
-       loopend = sp->v.loopend;
-       if (loopend > sampleend)
-               loopend = sampleend;
-
        /* be sure loop points start < end */
        if (sp->v.loopstart >= sp->v.loopend)
                swap(sp->v.loopstart, sp->v.loopend);
 
        /* compute true data size to be loaded */
        truesize = sp->v.size + BLANK_HEAD_SIZE;
-       loopsize = 0;
-#if 0 /* not supported */
-       if (sp->v.mode_flags & (SNDRV_SFNT_SAMPLE_BIDIR_LOOP|SNDRV_SFNT_SAMPLE_REVERSE_LOOP))
-               loopsize = sp->v.loopend - sp->v.loopstart;
-       truesize += loopsize;
-#endif
        if (sp->v.mode_flags & SNDRV_SFNT_SAMPLE_NO_BLANK)
                truesize += BLANK_LOOP_SIZE;
 
@@ -96,8 +86,8 @@ snd_emu10k1_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp,
        snd_emu10k1_synth_bzero(emu, sp->block, offset, size);
        offset += size;
 
-       /* copy start->loopend */
-       size = loopend;
+       /* copy provided samples */
+       size = sp->v.size;
        if (! (sp->v.mode_flags & SNDRV_SFNT_SAMPLE_8BITS))
                size *= 2;
        if (offset + size > blocksize)
@@ -108,53 +98,6 @@ snd_emu10k1_sample_new(struct snd_emux *rec, struct snd_sf_sample *sp,
                return -EFAULT;
        }
        offset += size;
-       data += size;
-
-#if 0 /* not supported yet */
-       /* handle reverse (or bidirectional) loop */
-       if (sp->v.mode_flags & (SNDRV_SFNT_SAMPLE_BIDIR_LOOP|SNDRV_SFNT_SAMPLE_REVERSE_LOOP)) {
-               /* copy loop in reverse */
-               if (! (sp->v.mode_flags & SNDRV_SFNT_SAMPLE_8BITS)) {
-                       int woffset;
-                       unsigned short *wblock = (unsigned short*)block;
-                       woffset = offset / 2;
-                       if (offset + loopsize * 2 > blocksize)
-                               return -EINVAL;
-                       for (i = 0; i < loopsize; i++)
-                               wblock[woffset + i] = wblock[woffset - i -1];
-                       offset += loopsize * 2;
-               } else {
-                       if (offset + loopsize > blocksize)
-                               return -EINVAL;
-                       for (i = 0; i < loopsize; i++)
-                               block[offset + i] = block[offset - i -1];
-                       offset += loopsize;
-               }
-
-               /* modify loop pointers */
-               if (sp->v.mode_flags & SNDRV_SFNT_SAMPLE_BIDIR_LOOP) {
-                       sp->v.loopend += loopsize;
-               } else {
-                       sp->v.loopstart += loopsize;
-                       sp->v.loopend += loopsize;
-               }
-               /* add sample pointer */
-               sp->v.end += loopsize;
-       }
-#endif
-
-       /* loopend -> sample end */
-       size = sp->v.size - loopend;
-       if (size < 0)
-               return -EINVAL;
-       if (! (sp->v.mode_flags & SNDRV_SFNT_SAMPLE_8BITS))
-               size *= 2;
-       if (snd_emu10k1_synth_copy_from_user(emu, sp->block, offset, data, size)) {
-               snd_emu10k1_synth_free(emu, sp->block);
-               sp->block = NULL;
-               return -EFAULT;
-       }
-       offset += size;
 
        /* clear rest of samples (if any) */
        if (offset < blocksize)