ice: remove dead code for allocating pin_config
authorJacob Keller <jacob.e.keller@intel.com>
Tue, 24 Aug 2021 00:01:47 +0000 (17:01 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Fri, 27 Aug 2021 16:11:39 +0000 (09:11 -0700)
We have code in the ice driver which allocates the pin_config structure
if n_pins is > 0, but we never set n_pins to be greater than zero.
There's no reason to keep this code until we actually have pin_config
support. Remove this. We can re-add it properly when we implement
support for pin_config for E810-T devices.

Fixes: 172db5f91d5f ("ice: add support for auxiliary input/output pins")
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Gurucharan G <gurucharanx.g@intel.com>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_ptp.c

index f54148fb0e2181ca34ffaffc8ab2a3665a4caa4e..09d74e94feae6cdbd6acd5a5dce2d7e7834069e4 100644 (file)
@@ -1064,17 +1064,6 @@ static long ice_ptp_create_clock(struct ice_pf *pf)
        info = &pf->ptp.info;
        dev = ice_pf_to_dev(pf);
 
-       /* Allocate memory for kernel pins interface */
-       if (info->n_pins) {
-               info->pin_config = devm_kcalloc(dev, info->n_pins,
-                                               sizeof(*info->pin_config),
-                                               GFP_KERNEL);
-               if (!info->pin_config) {
-                       info->n_pins = 0;
-                       return -ENOMEM;
-               }
-       }
-
        /* Attempt to register the clock before enabling the hardware. */
        clock = ptp_clock_register(info, dev);
        if (IS_ERR(clock))