scsi: target: core: Fix preempt and abort for allreg res

Match a key only if SARK is not zero according to SPC-4 and the comment
above the code:

 If an all registrants persistent reservation is present and the SERVICE
 ACTION RESERVATION KEY field is set to zero, then all registrations
 shall be removed except for that of the I_T nexus that is being used
 for the PERSISTENT RESERVE OUT command;

Without this patch in case of SARK==0 no registrants will be removed.

Link: https://lore.kernel.org/r/20220909090425.14479-2-d.bogdanov@yadro.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c
index a1d67554709f310c30e34703f582b9b6eaad707e..1521a97ddac25cfd0e5207a44b9598c0eeb48d1c 100644 (file)
--- a/drivers/target/target_core_pr.c
+++ b/drivers/target/target_core_pr.c
@@ -3022,7 +3022,7 @@ core_scsi3_pro_preempt(struct se_cmd *cmd, int type, int scope, u64 res_key,
                if (calling_it_nexus)
                        continue;
 
-               if (pr_reg->pr_res_key != sa_res_key)
+               if (sa_res_key && pr_reg->pr_res_key != sa_res_key)
                        continue;
 
                pr_reg_nacl = pr_reg->pr_reg_nacl;