NFSD: Clean up nfsd4_encode_seek()
authorChuck Lever <chuck.lever@oracle.com>
Mon, 9 Oct 2023 18:30:29 +0000 (14:30 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 16 Oct 2023 16:44:37 +0000 (12:44 -0400)
Use modern XDR encoder utilities.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index aa477ba2a6543ab95dc16b1a54dea7e1bcd78e09..ec4ed6206df1d1954860f16847d08740d2ad1a79 100644 (file)
@@ -5279,13 +5279,14 @@ nfsd4_encode_seek(struct nfsd4_compoundres *resp, __be32 nfserr,
                  union nfsd4_op_u *u)
 {
        struct nfsd4_seek *seek = &u->seek;
-       __be32 *p;
-
-       p = xdr_reserve_space(resp->xdr, 4 + 8);
-       *p++ = cpu_to_be32(seek->seek_eof);
-       p = xdr_encode_hyper(p, seek->seek_pos);
+       struct xdr_stream *xdr = resp->xdr;
 
-       return 0;
+       /* sr_eof */
+       nfserr = nfsd4_encode_bool(xdr, seek->seek_eof);
+       if (nfserr != nfs_ok)
+               return nfserr;
+       /* sr_offset */
+       return nfsd4_encode_offset4(xdr, seek->seek_pos);
 }
 
 static __be32