media: cedrus: Improve error messages for controls

Currently error messages when control creation fails are very sparse.
Granted, user should never observe them. However, developer working on
codecs can. In such cases additional information like which control
creation failed and error number are very useful.

Expand error messages with additional info.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Reviewed-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c b/drivers/staging/media/sunxi/cedrus/cedrus.c
index b12219123a6b0b8b0a8f9924e11a23fb474d7794..99c87319d2b43034208261a5a17dd44f8fb6083f 100644 (file)
--- a/drivers/staging/media/sunxi/cedrus/cedrus.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus.c
@@ -242,7 +242,8 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
        v4l2_ctrl_handler_init(hdl, CEDRUS_CONTROLS_COUNT);
        if (hdl->error) {
                v4l2_err(&dev->v4l2_dev,
-                        "Failed to initialize control handler\n");
+                        "Failed to initialize control handler: %d\n",
+                        hdl->error);
                return hdl->error;
        }
 
@@ -257,7 +258,9 @@ static int cedrus_init_ctrls(struct cedrus_dev *dev, struct cedrus_ctx *ctx)
                                            NULL);
                if (hdl->error) {
                        v4l2_err(&dev->v4l2_dev,
-                                "Failed to create new custom control\n");
+                                "Failed to create %s control: %d\n",
+                                v4l2_ctrl_get_name(cedrus_controls[i].cfg.id),
+                                hdl->error);
 
                        v4l2_ctrl_handler_free(hdl);
                        kfree(ctx->ctrls);