drm/i915/display/psr: Do full fetch when handling multi-planar formats
authorGwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Thu, 30 Sep 2021 00:14:02 +0000 (17:14 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Thu, 30 Sep 2021 22:04:37 +0000 (15:04 -0700)
We are still missing the PSR2 selective fetch handling of multi-planar
formats but until proper handle is added we can workaround it by
doing full frames fetch when state has such formats.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210930001409.254817-2-jose.souza@intel.com
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
drivers/gpu/drm/i915/display/intel_psr.c

index 3cdd193ddb13ffd505f75d76ecb365cf29bf4f5d..ba1739b5895ac333080a05a12ee75b6347dcce65 100644 (file)
@@ -1573,6 +1573,9 @@ static void cursor_area_workaround(const struct intel_plane_state *new_plane_sta
  * also planes are not updated if they have a negative X
  * position so for now doing a full update in this cases
  *
+ * TODO: We are missing multi-planar formats handling, until it is
+ * implemented it will send full frame updates.
+ *
  * Plane scaling and rotation is not supported by selective fetch and both
  * properties can change without a modeset, so need to be check at every
  * atomic commmit.
@@ -1582,6 +1585,7 @@ static bool psr2_sel_fetch_plane_state_supported(const struct intel_plane_state
        if (plane_state->uapi.dst.y1 < 0 ||
            plane_state->uapi.dst.x1 < 0 ||
            plane_state->scaler_id >= 0 ||
+           plane_state->hw.fb->format->num_planes > 1 ||
            plane_state->uapi.rotation != DRM_MODE_ROTATE_0)
                return false;