spi: lantiq-ssc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230303172041.2103336-34-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/drivers/spi/spi-lantiq-ssc.c b/drivers/spi/spi-lantiq-ssc.c
index aae26f62ea87ac31ce98f7d058af173a7318cf4f..76cf2a66f87497d39509663502946f68ef427666 100644 (file)
--- a/drivers/spi/spi-lantiq-ssc.c
+++ b/drivers/spi/spi-lantiq-ssc.c
@@ -1017,7 +1017,7 @@ err_master_put:
        return err;
 }
 
-static int lantiq_ssc_remove(struct platform_device *pdev)
+static void lantiq_ssc_remove(struct platform_device *pdev)
 {
        struct lantiq_ssc_spi *spi = platform_get_drvdata(pdev);
 
@@ -1030,13 +1030,11 @@ static int lantiq_ssc_remove(struct platform_device *pdev)
        destroy_workqueue(spi->wq);
        clk_disable_unprepare(spi->spi_clk);
        clk_put(spi->fpi_clk);
-
-       return 0;
 }
 
 static struct platform_driver lantiq_ssc_driver = {
        .probe = lantiq_ssc_probe,
-       .remove = lantiq_ssc_remove,
+       .remove_new = lantiq_ssc_remove,
        .driver = {
                .name = "spi-lantiq-ssc",
                .of_match_table = lantiq_ssc_match,