iio: adc: intel_mrfld_adc: use 'time_left' variable with wait_for_completion_interrup...
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Mon, 29 Apr 2024 11:33:07 +0000 (13:33 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 29 Apr 2024 20:06:18 +0000 (21:06 +0100)
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_interruptible_timeout() causing patterns like:

timeout = wait_for_completion_interruptible_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240429113313.68359-5-wsa+renesas@sang-engineering.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/intel_mrfld_adc.c

index 7263ad76124d70ca6d64285844e9b73231d0bded..c7f40ae6e6089a775a50042b2b58d717115548ef 100644 (file)
@@ -75,7 +75,7 @@ static int mrfld_adc_single_conv(struct iio_dev *indio_dev,
        struct mrfld_adc *adc = iio_priv(indio_dev);
        struct regmap *regmap = adc->regmap;
        unsigned int req;
-       long timeout;
+       long time_left;
        __be16 value;
        int ret;
 
@@ -95,13 +95,13 @@ static int mrfld_adc_single_conv(struct iio_dev *indio_dev,
        if (ret)
                goto done;
 
-       timeout = wait_for_completion_interruptible_timeout(&adc->completion,
-                                                           BCOVE_ADC_TIMEOUT);
-       if (timeout < 0) {
-               ret = timeout;
+       time_left = wait_for_completion_interruptible_timeout(&adc->completion,
+                                                             BCOVE_ADC_TIMEOUT);
+       if (time_left < 0) {
+               ret = time_left;
                goto done;
        }
-       if (timeout == 0) {
+       if (time_left == 0) {
                ret = -ETIMEDOUT;
                goto done;
        }