projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
77b9f2d
)
leds: trigger: netdev: Remove not needed call to led_set_brightness in deactivate
author
Heiner Kallweit
<hkallweit1@gmail.com>
Fri, 5 Apr 2024 20:53:08 +0000
(22:53 +0200)
committer
Lee Jones
<lee@kernel.org>
Fri, 12 Apr 2024 08:47:14 +0000
(09:47 +0100)
led_trigger_set() is the only caller of the deactivate() callback,
and it calls led_set_brightness(LED_OFF) anyway after deactivate().
So we can remove the call here.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link:
https://lore.kernel.org/r/8dc929e7-8e14-4c85-aa28-9c5fe2620f52@gmail.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/trigger/ledtrig-netdev.c
patch
|
blob
|
history
diff --git
a/drivers/leds/trigger/ledtrig-netdev.c
b/drivers/leds/trigger/ledtrig-netdev.c
index ea00f6c708826b4e01745bb31320c59917c1de24..22bba8e97642a49822e17b1b0ae6942aad3394e1 100644
(file)
--- a/
drivers/leds/trigger/ledtrig-netdev.c
+++ b/
drivers/leds/trigger/ledtrig-netdev.c
@@
-724,8
+724,6
@@
static void netdev_trig_deactivate(struct led_classdev *led_cdev)
cancel_delayed_work_sync(&trigger_data->work);
- led_set_brightness(led_cdev, LED_OFF);
-
dev_put(trigger_data->net_dev);
kfree(trigger_data);