python: Fix .PHONY Make specifiers
authorJohn Snow <jsnow@redhat.com>
Tue, 29 Jun 2021 21:43:17 +0000 (17:43 -0400)
committerJohn Snow <jsnow@redhat.com>
Thu, 1 Jul 2021 01:54:04 +0000 (21:54 -0400)
I missed the 'check-tox' target. Add that, but split the large .PHONY
specifier at the top into its component pieces and move them near the
targets they describe so that they're much harder to forget to update.

Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Message-id: 20210629214323.1329806-10-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
python/Makefile

index d2cfa6ad8f18adbe58e536241249a87375609fe0..d34c4e35d9b8bc95473032bb33b0853f97d31321 100644 (file)
@@ -1,5 +1,4 @@
-.PHONY: help pipenv check-pipenv check clean distclean develop
-
+.PHONY: help
 help:
        @echo "python packaging help:"
        @echo ""
@@ -29,25 +28,32 @@ help:
        @echo "                 built distribution files, and everything"
        @echo "                 from 'make clean'."
 
+.PHONY: pipenv
 pipenv: .venv
 .venv: Pipfile.lock
        @PIPENV_VENV_IN_PROJECT=1 pipenv sync --dev --keep-outdated
        @touch .venv
 
+.PHONY: check-pipenv
 check-pipenv: pipenv
        @pipenv run make check
 
+.PHONY: develop
 develop:
        pip3 install -e .[devel]
 
+.PHONY: check
 check:
        @avocado --config avocado.cfg run tests/
 
+.PHONY: check-tox
 check-tox:
        @tox
 
+.PHONY: clean
 clean:
        python3 setup.py clean --all
 
+.PHONY: distclean
 distclean: clean
        rm -rf qemu.egg-info/ .venv/ .tox/ dist/