powerpc/powernv/sriov: Fix use of uninitialised variable
authorOliver O'Halloran <oohall@gmail.com>
Mon, 3 Aug 2020 07:54:08 +0000 (17:54 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 3 Aug 2020 12:13:13 +0000 (22:13 +1000)
Initialising the value before using it is generally regarded as a good
idea so do that.

Fixes: 4c51f3e1e870 ("powerpc/powernv/sriov: Make single PE mode a per-BAR setting")
Reported-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200803075408.132601-1-oohall@gmail.com
arch/powerpc/platforms/powernv/pci-sriov.c

index 7894745fd4f8583fe2bb0ca63196043dcad184ae..c4434f20f42fae901b3024ecd16fbce2045e6d89 100644 (file)
@@ -253,9 +253,9 @@ void pnv_pci_ioda_fixup_iov(struct pci_dev *pdev)
 resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev,
                                                      int resno)
 {
+       resource_size_t align = pci_iov_resource_size(pdev, resno);
        struct pnv_phb *phb = pci_bus_to_pnvhb(pdev->bus);
        struct pnv_iov_data *iov = pnv_iov_get(pdev);
-       resource_size_t align;
 
        /*
         * iov can be null if we have an SR-IOV device with IOV BAR that can't
@@ -266,8 +266,6 @@ resource_size_t pnv_pci_iov_resource_alignment(struct pci_dev *pdev,
        if (!iov)
                return align;
 
-       align = pci_iov_resource_size(pdev, resno);
-
        /*
         * If we're using single mode then we can just use the native VF BAR
         * alignment. We validated that it's possible to use a single PE