staging: r8188eu: merge _ReadLEDSetting() into ReadAdapterInfo8188EU()
authorMichael Straube <straube.linux@gmail.com>
Tue, 28 Dec 2021 10:11:20 +0000 (11:11 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 28 Dec 2021 16:14:29 +0000 (17:14 +0100)
Function _ReadLEDSetting() sets only a single variable and the only
user is ReadAdapterInfo8188EU(). Remove _ReadLEDSetting() and set the
variable in ReadAdapterInfo8188EU() directly.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20211228101120.9120-11-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/r8188eu/hal/usb_halinit.c

index 293a616eabc62280d93f614f689232d2d6126e69..d5c7e8bf1f38a3fc09a3343763cf3f721a4e2c4a 100644 (file)
@@ -913,12 +913,6 @@ exit:
 /*     EEPROM/EFUSE Content Parsing */
 /*  */
 /*  */
-static void _ReadLEDSetting(struct adapter *Adapter, u8 *PROMContent, bool AutoloadFail)
-{
-       struct led_priv *pledpriv = &Adapter->ledpriv;
-
-       pledpriv->bRegUseLed = true;
-}
 
 static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool AutoLoadFail)
 {
@@ -938,6 +932,7 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
 void ReadAdapterInfo8188EU(struct adapter *Adapter)
 {
        struct eeprom_priv *eeprom = &Adapter->eeprompriv;
+       struct led_priv *ledpriv = &Adapter->ledpriv;
        u8 eeValue;
 
        /*  Read EEPROM size before call any EEPROM function */
@@ -965,7 +960,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter)
        Hal_ReadAntennaDiversity88E(Adapter, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag);
        Hal_ReadThermalMeter_88E(Adapter, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag);
 
-       _ReadLEDSetting(Adapter, eeprom->efuse_eeprom_data, eeprom->bautoload_fail_flag);
+       ledpriv->bRegUseLed = true;
 }
 
 static void ResumeTxBeacon(struct adapter *adapt)